-
Notifications
You must be signed in to change notification settings - Fork 7
Replace a single Guava call causing dependency hell #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The method in Guava moved from class 'Objects' to 'MoreObjects'. This minimalist change avoids 'dependency-hell' while not requiring a Guava verision bump. Thus, upstream code can upgrade to Guava 21 or higher without encountering a runtime crash in this module.
For reference: this fix is for an issue originally logged against fge/jackson-coreutils (issue 12) |
we also need this exact fix too in order to pick up a newer version of guava |
Hi @huggsboson, thanks for forking this project. Can you say anything about the likely timeline for this to be merged (and then I suppose a .jar would also need to be published for people to reference) ? |
@huggsboson please help to cut another release with this PR? |
I'll crank one out, but won't be able to do it until later in the day. |
@huggsboson ping :-) |
tested locally |
merged |
|
patch is up to date with the new dependency at 1.10:
|
now for schema-core and then validator. |
json-schema-core should be updated with the new dependency.
|
json-schema-validator should be updated with the new dependency (plus a few other changes):
|
k. All the libraries are updated. Let me know if you run into any problems. Also @lukeu I'd love to add you to the repositories / maven so you can help with merging and releasing if you're interested. |
I am able to pickup json-schema-core 1.2.9 which has the fix for this PR. Not able to upgrade to latest json-schema-validator, due to test failure at my app. I now can use newer version of guava Thanks to the new release |
Is the test failure due to changes in schema validator? I did merge a few
other changes with that.
…On Sun, May 13, 2018, 3:34 AM Dan Tran ***@***.***> wrote:
I am able to pickup json-schema-core 1.2.9 which has the fix for this PR.
Not able to upgrade to latest json-schema-validator, due to test failure
at my app.
I now can use newer version of guava
Thanks to the new release
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADUzzFSijANyyX_vZ-WnaLI4whRlEtp_ks5tyAw_gaJpZM4S365z>
.
|
yes i am stuck with json-schema-validator-1.2.8. very likely the changes at 1.2.9 causing my app junit test to fail. We spend some time to look into details |
Hmm yeah let me know. Worried some other change may have added a
regression.
…On Sun, May 13, 2018, 5:03 PM Dan Tran ***@***.***> wrote:
yes i am stuck with json-schema-validator-1.2.8. very likely the changes
at 1.2.9 causing my app junit test to fail. We spend some time to look into
details
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADUzzCJzvz8iy4daKL83P9tsfxNPg1Sgks5tyMm-gaJpZM4S365z>
.
|
here is error string extracted from build log ( not I am not the owner this test case) Expected: a collection containing "/links/0: object has missing required properties (["href"])" I believe there were changes at with DateTime at json-schema-validator |
looks like some default date format got changed |
java-json-tools/json-schema-validator@728b3da introduce new default behavior Best not do that in minor version release |
fair point |
I thought the addition of fractions was optional. I'll add a test and fix the behavior. |
I believe it's the lack of colon in your timezone offset. |
RFC3339 specifies that offsets should have colons in them:
https://tools.ietf.org/html/rfc3339#section-5.6 My temptation is to inject a setting to allow you to use the old date time formatter for now, so you can migrate over at your leisure. |
@dantran Mind taking a look at: |
The method in Guava moved from class 'Objects' to 'MoreObjects'.
This minimalist change avoids 'dependency-hell' while not requiring
a Guava verision bump. Thus, upstream code can upgrade to Guava 21
or higher without encountering a runtime crash in this module.