Skip to content

Replace a single Guava call causing dependency hell #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lukeu
Copy link

@lukeu lukeu commented Mar 22, 2018

The method in Guava moved from class 'Objects' to 'MoreObjects'.

This minimalist change avoids 'dependency-hell' while not requiring
a Guava verision bump. Thus, upstream code can upgrade to Guava 21
or higher without encountering a runtime crash in this module.

The method in Guava moved from class 'Objects' to 'MoreObjects'.

This minimalist change avoids 'dependency-hell' while not requiring
a Guava verision bump. Thus, upstream code can upgrade to Guava 21
or higher without encountering a runtime crash in this module.
@lukeu
Copy link
Author

lukeu commented Mar 22, 2018

For reference: this fix is for an issue originally logged against fge/jackson-coreutils (issue 12)

@dantran
Copy link

dantran commented Apr 19, 2018

we also need this exact fix too in order to pick up a newer version of guava

@lukeu
Copy link
Author

lukeu commented Apr 19, 2018

Hi @huggsboson, thanks for forking this project. Can you say anything about the likely timeline for this to be merged (and then I suppose a .jar would also need to be published for people to reference) ?

@dantran
Copy link

dantran commented May 4, 2018

@huggsboson please help to cut another release with this PR?

@huggsboson
Copy link
Member

I'll crank one out, but won't be able to do it until later in the day.

@dantran
Copy link

dantran commented May 10, 2018

@huggsboson ping :-)

@huggsboson
Copy link
Member

tested locally

@huggsboson
Copy link
Member

merged

@huggsboson huggsboson closed this May 12, 2018
@huggsboson
Copy link
Member

sorry it took so long @lukeu @dantran . I've got a 1.9 uploaded to mavencentral and i'll work on wiring it through json-patch and json-schema-core

@huggsboson
Copy link
Member

huggsboson commented May 12, 2018

<dependency>
  <groupId>com.github.java-json-tools</groupId>
  <artifactId>jackson-coreutils</artifactId>
  <version>1.9</version>
</dependency>

@huggsboson
Copy link
Member

huggsboson commented May 12, 2018

patch is up to date with the new dependency at 1.10:

<dependency>
  <groupId>com.github.java-json-tools</groupId>
  <artifactId>json-patch</artifactId>
  <version>1.10</version>
</dependency>

@huggsboson
Copy link
Member

now for schema-core and then validator.

@huggsboson
Copy link
Member

json-schema-core should be updated with the new dependency.

<dependency>
  <groupId>com.github.java-json-tools</groupId>
  <artifactId>json-schema-core</artifactId>
  <version>1.2.9</version>
</dependency>

@huggsboson
Copy link
Member

json-schema-validator should be updated with the new dependency (plus a few other changes):

<dependency>
  <groupId>com.github.java-json-tools</groupId>
  <artifactId>json-schema-validator</artifactId>
  <version>2.2.9</version>
</dependency>

@huggsboson
Copy link
Member

k. All the libraries are updated. Let me know if you run into any problems. Also @lukeu I'd love to add you to the repositories / maven so you can help with merging and releasing if you're interested.

@dantran
Copy link

dantran commented May 13, 2018

I am able to pickup json-schema-core 1.2.9 which has the fix for this PR.

Not able to upgrade to latest json-schema-validator, due to test failure at my app.

I now can use newer version of guava

Thanks to the new release

@huggsboson
Copy link
Member

huggsboson commented May 13, 2018 via email

@dantran
Copy link

dantran commented May 14, 2018

yes i am stuck with json-schema-validator-1.2.8. very likely the changes at 1.2.9 causing my app junit test to fail. We spend some time to look into details

@huggsboson
Copy link
Member

huggsboson commented May 14, 2018 via email

@dantran
Copy link

dantran commented May 14, 2018

here is error string extracted from build log ( not I am not the owner this test case)

Expected: a collection containing "/links/0: object has missing required properties (["href"])"
but: was "/createdTime: string "2015-05-23T10:44:04.295+0200" is invalid against requested date format(s) [yyyy-MM-dd'T'HH:mm:ss((+|-)HH:mm|Z), yyyy-MM-dd'T'HH:mm:ss.[0-9]{1,12}((+|-)HH:mm|Z)]"

I believe there were changes at with DateTime at json-schema-validator

@dantran
Copy link

dantran commented May 14, 2018

looks like some default date format got changed

@dantran
Copy link

dantran commented May 14, 2018

java-json-tools/json-schema-validator@728b3da introduce new default behavior

Best not do that in minor version release

@huggsboson
Copy link
Member

fair point

@huggsboson
Copy link
Member

I thought the addition of fractions was optional. I'll add a test and fix the behavior.

@huggsboson
Copy link
Member

I believe it's the lack of colon in your timezone offset.

@huggsboson
Copy link
Member

RFC3339 specifies that offsets should have colons in them:

time-numoffset  = ("+" / "-") time-hour ":" time-minute
time-offset     = "Z" / time-numoffset

https://tools.ietf.org/html/rfc3339#section-5.6

My temptation is to inject a setting to allow you to use the old date time formatter for now, so you can migrate over at your leisure.

@huggsboson
Copy link
Member

@dantran Mind taking a look at:
java-json-tools/json-schema-validator#262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants